Messages in this thread | | | Date | Tue, 19 Jul 2022 08:51:54 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] virtio: Force DMA restricted devices through DMA API |
| |
On Tue, Jul 19, 2022 at 03:46:08PM +0000, Keir Fraser wrote: > However, if the general idea at least is acceptable, would the > implementation be acceptable if I add an explicit API for this to the > DMA subsystem, and hide the detail there?
I don't think so. The right thing to key off is VIRTIO_F_ACCESS_PLATFORM, which really should be set in any modern virtio device after all the problems we had with the lack of it.
> Or a completely different approach would be to revert the patch > e41b1355508d which clears VIRTIO_F_ACCESS_PLATFORM in the balloon > driver. MST: That's back in your court, as it's your patch!
Which also means this needs to be addresses, but I don't think a simple revert is enough.
| |