Messages in this thread | | | Date | Tue, 19 Jul 2022 17:25:57 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco) |
| |
> +static void ovpn_get_drvinfo(struct net_device *dev, > + struct ethtool_drvinfo *info) > +{ > + strscpy(info->driver, DRV_NAME, sizeof(info->driver)); > + strscpy(info->version, DRV_VERSION, sizeof(info->version)); > + strscpy(info->bus_info, "ovpn", sizeof(info->bus_info));
version is generally considered useless information if it comes from the driver. You have no idea if this is version 42 in net-next, or some backported version in an enterprise kernel with lots of out of tree patches. The driver is not standalone, it runs inside the kernel. So in order to understand a bug report, you need to know what kernel it is. If you don't fill in version, the core will with the kernel version, which is much more useful.
Andrew
| |