lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper
On Tue, 19 Jul 2022 13:23:06 +0800
Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:

> > Care to send me a patch, and I'll just include it in my series?
> Seems no need add another patch, just modify this patch as below:
>
> diff --git a/drivers/usb/mtu3/mtu3_trace.h
> b/drivers/usb/mtu3/mtu3_trace.h
> index a09deae1146f..03d2a9bac27e 100644
> --- a/drivers/usb/mtu3/mtu3_trace.h
> +++ b/drivers/usb/mtu3/mtu3_trace.h
> @@ -18,18 +18,16 @@
>
> #include "mtu3.h"
>
> -#define MTU3_MSG_MAX 256
> -
> TRACE_EVENT(mtu3_log,
> TP_PROTO(struct device *dev, struct va_format *vaf),
> TP_ARGS(dev, vaf),
> TP_STRUCT__entry(
> __string(name, dev_name(dev))
> - __dynamic_array(char, msg, MTU3_MSG_MAX)
> + __vstring(msg, vaf->fmt, vaf->va)
> ),
> TP_fast_assign(
> __assign_str(name, dev_name(dev));
> - vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf-
> >va);
> + __assign_vstr(msg, vaf->fmt, vaf->va);
> ),
> TP_printk("%s: %s", __get_str(name), __get_str(msg))
> );
> >
>
> remove below two lines
> "
> -#define MTU3_MSG_MAX 256
> -

Fine.

Even though I already pushed to linux-next, I did something I seldom do. I
rebased my for-next branch and removed this patch.

I'll send a v2.

-- Steve

\
 
 \ /
  Last update: 2022-07-19 17:26    [W:0.103 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site