Messages in this thread | | | Date | Tue, 19 Jul 2022 17:19:07 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco) |
| |
> +void ovpn_crypto_key_slot_delete(struct ovpn_crypto_state *cs, > + enum ovpn_key_slot slot) > +{ > + struct ovpn_crypto_key_slot *ks = NULL; > + > + mutex_lock(&cs->mutex); > + switch (slot) { > + case OVPN_KEY_SLOT_PRIMARY: > + ks = rcu_replace_pointer(cs->primary, NULL, > + lockdep_is_held(&cs->mutex)); > + break; > + case OVPN_KEY_SLOT_SECONDARY: > + ks = rcu_replace_pointer(cs->secondary, NULL, > + lockdep_is_held(&cs->mutex)); > + break; > + default: > + pr_warn("Invalid slot to release: %u\n", slot); > + break; > + } > + mutex_unlock(&cs->mutex); > + > + if (!ks) { > + pr_debug("Key slot already released: %u\n", slot); > + return; > + } > + pr_debug("deleting key slot %u, key_id=%u\n", slot, ks->key_id);
As a general comment throughout the code, pr_ functions are not liked. Since this is a network device, it would be better to use netdev_debug(), netdev_warn() etc, so indicating which device is outputting warnings or debug info.
Andrew
| |