Messages in this thread | | | Date | Tue, 19 Jul 2022 16:05:13 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes |
| |
On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote: > On 19/07/2022 15:22, Geert Uytterhoeven wrote: > > Hi Sudeep, > > > > Hey Geert, > [...]
> > > > This is triggered > > > > Early cacheinfo failed, ret = -12 > > > > on all my RV64 platforms (K210, PolarFire, StarLight). > > This should be fixed by Sudeeps most recent patchset, at least > it was when I tested it! > https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/ >
Conor you beat me in the response speed :).
> > -12 = -ENOMEM. > > > > The boot continues regardless, and the K210 even has enough spare > > RAM after boot to run "ls", unlike two weeks ago ;-) > >
Yes Conor initially reported this and I suspected something to do with per-cpu allocation as the early cacheinfo failed but succeeded in device initcall level. However when fixing some hotplug issue, I moved the detection of cache attributes on all cpus from boot cpu to individual CPUs in the secondary startup which seem to fix the issue as I assume the per-cpu allocation is ready to use at that stage.
However we still have one pending issue[0] to address even after [1], but that doesn't affect DT platforms.
-- Regards, Sudeep
[0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/ [1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/
| |