lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder Lake-N and Raptor Lake-P
Date


> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Saturday, July 16, 2022 1:19 AM
> To: Pawnikar, Sumeet R <sumeet.r.pawnikar@intel.com>
> Cc: rafael@kernel.org; srinivas.pandruvada@linux.intel.com; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder
> Lake-N and Raptor Lake-P
>
> On Fri, Jul 15, 2022 at 10:22:28PM +0530, Sumeet Pawnikar wrote:
> > Add Alder Lake-N and Raptor Lake-P to the list of processor models for
> > which Power Limit4 is supported by the Intel RAPL driver.
> >
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> You may not convert people's review into a tag without their consent.
> But taking into account this is trivial patch, it's fine. Just follow the rules next
> time.
>
Thanks for your time to review this.
Got your point. I'll follow this rule going forward.

> Also, where is v1? What are the differences to it?
>
Sorry for this confusion. Actually this is the v2 version in the internal review,
I forgot to remove the v2 prefix when submitting externally.
I'll resend this patch removing v2.

Thanks,
Sumeet.

> > ---
> > drivers/powercap/intel_rapl_msr.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/powercap/intel_rapl_msr.c
> > b/drivers/powercap/intel_rapl_msr.c
> > index 9d23984d8931..bc6adda58883 100644
> > --- a/drivers/powercap/intel_rapl_msr.c
> > +++ b/drivers/powercap/intel_rapl_msr.c
> > @@ -140,7 +140,9 @@ static const struct x86_cpu_id pl4_support_ids[] = {
> > { X86_VENDOR_INTEL, 6, INTEL_FAM6_TIGERLAKE_L,
> X86_FEATURE_ANY },
> > { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE,
> X86_FEATURE_ANY },
> > { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_L,
> X86_FEATURE_ANY },
> > + { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_N,
> X86_FEATURE_ANY },
> > { X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE,
> X86_FEATURE_ANY },
> > + { X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE_P,
> X86_FEATURE_ANY },
> > {}
> > };
>
> --
> With Best Regards,
> Andy Shevchenko
>

\
 
 \ /
  Last update: 2022-07-19 16:40    [W:0.172 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site