Messages in this thread | | | Date | Tue, 19 Jul 2022 09:34:22 +0200 | Subject | Re: [PATCH] dt-bindings: leds: lp50xx: fix LED children names | From | Krzysztof Kozlowski <> |
| |
On 18/07/2022 17:18, Rob Herring wrote: > On Fri, Jun 24, 2022 at 5:13 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> The lp50xx LEDs expects to have single-color LED children with unit >> addresses. This is required by the driver and provided by existing >> DTSes. Fix the binding to match actual usage. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers") >> --- >> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> index f12fe5b53f30..c274a10bbde6 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> @@ -65,8 +65,14 @@ patternProperties: >> for the child node. The LED modules can either be used stand alone >> or grouped into a module bank. >> >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> patternProperties: >> - "(^led-[0-9a-f]$|led)": >> + "^led@[0-9a-f]+$": > > Looks like you forgot to update the example. Now failing with > 'unevaluatedProperties' fixed:
Yeah, this was fixed in my other patch: https://lore.kernel.org/all/20220607075247.58048-1-krzysztof.kozlowski@linaro.org/
and I assumed Pavel will also pick it up... It has been waiting for more than one month.
Best regards, Krzysztof
| |