Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next 2/3] firmware: stratix10-svc: fix memory leak when platform_device_alloc/add() fails | Date | Tue, 19 Jul 2022 22:02:56 +0800 |
| |
If platform_device_alloc/add() failed in stratix10_svc_drv_probe(), 'svc_fifo' and 'genpool' should be freed.
Fixes: e6281c26674e ("firmware: stratix10-svc: Add support for FCS") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/firmware/stratix10-svc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index 1a5640b3ab42..cb824f63faa8 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -1202,19 +1202,20 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) ret = platform_device_add(svc->stratix10_svc_rsu); if (ret) { platform_device_put(svc->stratix10_svc_rsu); - return ret; + goto err_free_kfifo; } svc->intel_svc_fcs = platform_device_alloc(INTEL_FCS, 1); if (!svc->intel_svc_fcs) { dev_err(dev, "failed to allocate %s device\n", INTEL_FCS); - return -ENOMEM; + ret = -ENOMEM; + goto err_free_kfifo; } ret = platform_device_add(svc->intel_svc_fcs); if (ret) { platform_device_put(svc->intel_svc_fcs); - return ret; + goto err_free_kfifo; } dev_set_drvdata(dev, svc); -- 2.25.1
| |