Messages in this thread | | | Date | Tue, 19 Jul 2022 15:35:18 +0200 | From | Christian Marangi <> | Subject | Re: [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary exposed function and make them static |
| |
On Tue, Jul 19, 2022 at 04:29:31PM +0300, Vladimir Oltean wrote: > On Tue, Jul 19, 2022 at 02:57:26AM +0200, Christian Marangi wrote: > > Some function were exposed to permit migration to common code. Drop them > > and make them static now that the user are in the same common code. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > Hmm, ideally the last patch that removes a certain function from being > called from qca8k-8xxx.c would also delete its prototype and make it > static in qca8k-common.c. Would that be hard to change?
Can be done, it's really to compile check the changes and fix them. Problem is that the patch number would explode. (ok explode is a big thing but i think that would add 2-3 more patch to this big series... this is why I did the static change as the last patch instead of in the middle of the series)
But yes it's totally doable and not that hard honestly.
-- Ansuel
| |