lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] random: handle archrandom in plural words
Hi Mark,

On Tue, Jul 19, 2022 at 2:42 PM Mark Rutland <mark.rutland@arm.com> wrote:
> > -static inline bool __must_check arch_get_random_long(unsigned long *v)
> > +static inline size_t __must_check arch_get_random_words(unsigned long *v, size_t words)
>
> As others have suggested, could we please s/words/longs/? That's a smaller
> change from the existing name, and avoids amibugity were "word" has an
> architecture-specific meaning. e.g. the ARM ARM (ARM DDI 0487G.b) defines:

At first I had thought, "erm, I like 'words'" but decided to wait it
out, and now it's two people with the same probably good objection to
'words', so I'll send a v+1 with 'longs' instead. Thanks for your
feedback. Patch incoming.

> FWIW, other than the naming nits, the arm64 bits look fine to me.

Oh good. Can you send an Acked-by for v+1? Coming up shortly.

Jason

\
 
 \ /
  Last update: 2022-07-19 15:32    [W:0.298 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site