[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [net-next RFC PATCH 0/4] net: dsa: qca8k: code split for qca8k
On Mon, Jul 18, 2022 at 07:23:35PM +0200, Christian Marangi wrote:
> Ok, so I have to keep the qca8k special function. Is it a problem if I
> keep the function and than later make the conversion when we have the
> regmap dependency merged?

You mean to ask whether there's any problem if the common qca8k_fdb_read()
calls the specific qca8k_bulk_read as opposed to regmap_bulk_read()?

Well, no, considering that you don't yet support the switch with the
MMIO regmap, the common code is still "common" for the single switch
that the driver supports. You should be able to continue making progress
with qca8k_bulk_read() being called from common code (as long as you
leave a TODO comment or something, that it doesn't really belong there).

 \ /
  Last update: 2022-07-18 20:17    [W:0.143 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site