Messages in this thread | | | Date | Mon, 18 Jul 2022 20:38:17 +0300 | From | Vladimir Oltean <> | Subject | Re: [net-next RFC PATCH 4/4] net: dsa: qca8k: split qca8k in common and 8xxx specific code |
| |
On Mon, Jul 18, 2022 at 07:10:52PM +0200, Christian Marangi wrote: > On Mon, Jul 18, 2022 at 08:21:35PM +0300, Vladimir Oltean wrote: > > On Sat, Jul 16, 2022 at 07:49:58PM +0200, Christian Marangi wrote: > > > The qca8k family reg structure is also used in the internal ipq40xx > > > switch. Split qca8k common code from specific code for future > > > implementation of ipq40xx internal switch based on qca8k. > > > > > > While at it also fix minor wrong format for comments and reallign > > > function as we had to drop static declaration. > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > > --- > > > drivers/net/dsa/qca/Makefile | 1 + > > > drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} | 1210 +---------------- > > > drivers/net/dsa/qca/qca8k-common.c | 1174 ++++++++++++++++ > > > drivers/net/dsa/qca/qca8k.h | 58 + > > > 4 files changed, 1245 insertions(+), 1198 deletions(-) > > > rename drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} (64%) > > > create mode 100644 drivers/net/dsa/qca/qca8k-common.c > > > > Sorry, this patch is very difficult to review for correctness. > > Could you try to split it to multiple individual function movements? > > You are right. > Can I split them in category function (bridge function, vlan function, > ATU...) Or you want them even more split?
Yes, I think splitting by category is OK as long as the number of functions being moved at once is trackable by a human being (I'd say at most 5 functions or so). Use your own judgement while looking at the output of git format-patch (essentially what a reviewer is looking at).
| |