lkml.org 
[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two funcs
    On Mon, Jul 18, 2022 at 09:37:08AM -0400, Jim Quinlan wrote:
    > On Mon, Jul 18, 2022 at 9:11 AM Pali Rohár <pali@kernel.org> wrote:
    > >
    > > Hello!
    > >
    > > On Saturday 16 July 2022 18:24:49 Jim Quinlan wrote:
    > > > @@ -948,6 +941,40 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
    > > > if (pcie->gen)
    > > > brcm_pcie_set_gen(pcie, pcie->gen);
    > > >
    > > > + /* Don't advertise L0s capability if 'aspm-no-l0s' */
    > > > + aspm_support = PCIE_LINK_STATE_L1;
    > > > + if (!of_property_read_bool(pcie->np, "aspm-no-l0s"))
    > > > + aspm_support |= PCIE_LINK_STATE_L0S;
    > > > + tmp = readl(base + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY);
    > > > + u32p_replace_bits(&tmp, aspm_support,
    > > > + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_MASK);
    > > > + writel(tmp, base + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY);
    > > > +
    > > > + /*
    > > > + * For config space accesses on the RC, show the right class for
    > > > + * a PCIe-PCIe bridge (the default setting is to be EP mode).
    > > > + */
    > > > + tmp = readl(base + PCIE_RC_CFG_PRIV1_ID_VAL3);
    > > > + u32p_replace_bits(&tmp, 0x060400,
    > >
    > > There is already macro PCI_CLASS_BRIDGE_PCI_NORMAL, so please use it
    > > instead of magic constant.
    >
    > Will do, thanks.

    I can fix that up locally.

    > > I introduced it recently in commit:
    > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=904b10fb189cc15376e9bfce1ef0282e68b0b004
    > >
    > > > + PCIE_RC_CFG_PRIV1_ID_VAL3_CLASS_CODE_MASK);
    > > > + writel(tmp, base + PCIE_RC_CFG_PRIV1_ID_VAL3);
    > > > +
    > > > + return 0;
    > > > +}



    > _______________________________________________
    > linux-arm-kernel mailing list
    > linux-arm-kernel@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

    \
     
     \ /
      Last update: 2022-07-18 19:05    [W:2.996 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site