lkml.org 
[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/8] PCI: qcom: Add support for SC8280XP and SA8540P
On Fri, Jul 15, 2022 at 05:37:28PM -0500, Bjorn Helgaas wrote:
> On Thu, Jul 14, 2022 at 09:13:40AM +0200, Johan Hovold wrote:
> > This series adds support for the PCIe controllers found on SC8280XP and
> > SA8540P.
>
> These look fairly straightforward, and I don't mind doing minor tweaks
> and conflict resolution, but given that we've got four or five cooks
> in the qcom kitchen, I'm looking for an ack from Stan before spending
> too much time on this.

Sounds good. Stan's acked the series now too.

Since I rebased v2 on qcom-pending (and added the missing pipe clock
patch), there shouldn't be any conflicts and the only fixup I'm aware of
is the sort order of the "qcom,pcie-ipq4019" entry in patch 8/8.

Let me know if you prefer I fix that in a v3 otherwise these can be
applied once the MSI series has been merged.

I saw Stan acking the binding in that series, not sure if the intention
was to ack the whole series?

https://lore.kernel.org/all/3f9e1c18-bc61-8690-5427-ba8dc5fad7ad@mm-sol.com/

> > Included are also three patches that clean up the way the driver handles
> > different IP revisions (e.g. by modelling optional clocks as being truly
> > optional).
> >
> > These patches depend on the recently merged (but currently held off?)
> > PIPE clock series:
> >
> > https://lore.kernel.org/all/20220608105238.2973600-1-dmitry.baryshkov@linaro.org/
>
> As far as I know it's on pci/ctrl/qcom [1], in -next, and ready to go.
> It's based on Bjorn A's immutable branch [2].

Right.

> > as well as the about-to-be-merged MSI series (v17):
> >
> > https://lore.kernel.org/all/20220707134733.2436629-6-dmitry.baryshkov@linaro.org/
> >
> > Note that the final patch in the PIPE clock series is currently missing
> > from the pci/ctrl/qcom-pending branch:
> >
> > https://lore.kernel.org/all/20220608105238.2973600-6-dmitry.baryshkov@linaro.org/
>
> I think I fixed that, let me know if not; see [1].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=839fbdee4c08
> [2] https://lore.kernel.org/linux-pci/YroMyWNO8ZLk1bTe@builder.lan/

It appears to have been fixed in your branch now, but it hasn't yet made
it into -next.

> > Changes in v2
> > - drop the two DT schema fixes which have been applied by Bjorn H and
> > squashed into the MSI v17 series by Dmitry, respectively
> > - rebase on pci/ctrl/qcom-pending (2022-07-14)
> > - fix compatible sort order (Krzysztof)
> > - amend commit message for first patch to clarify motivation
> > (Krzysztof)
> > - add acks and reviewed-by tags from Dmitry, Krzysztof, Mani and Rob
> >
> >
> > Johan Hovold (8):
> > dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt
> > dt-bindings: PCI: qcom: Add SC8280XP to binding
> > dt-bindings: PCI: qcom: Add SA8540P to binding
> > PCI: qcom: Add support for SC8280XP
> > PCI: qcom: Add support for SA8540P
> > PCI: qcom: Make all optional clocks optional
> > PCI: qcom: Clean up IP configurations
> > PCI: qcom: Sort device-id table

Johan

\
 
 \ /
  Last update: 2022-07-18 12:16    [W:0.170 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site