Messages in this thread | | | Date | Mon, 18 Jul 2022 11:51:26 +0200 | From | Peter Zijlstra <> | Subject | Re: schedstat false counting of domain load_balance() tried to move one or more tasks failed |
| |
On Tue, Jul 12, 2022 at 09:52:59PM -0400, Steven Rostedt wrote: > I've been tasked to analyze the /proc/schedstat file to determine > appropriate metrics to look after in production. So I'm looking at both the > documentation and the code that generates it. > > From the documentation at https://docs.kernel.org/scheduler/sched-stats.html > > (and Documentation/scheduler/sched-stats.rst for those of you that are > allergic to html)
I'm allergic to both, it's plain text or bust.
> 3) # of times in this domain load_balance() tried to move one or > more tasks and failed, when the cpu was idle
> Thus, if we get to that check for (busiest->nr_running > 1) and fail, then > we will increment that counter incorrectly. > > Do we care? Should it be fixed? Should it be documented?
*shrug*, I suppose we can fix. People using this stuff are the sort that are likely to read documentation instead of code.
At the same time; I suspect it's been 'broken' like forever, so who knows what people are actually expecting today.
| |