lkml.org 
[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] crypto: hisilicon/hpre - don't use GFP_KERNEL to alloc mem during softirq
From
On 2022/7/19 10:16, Herbert Xu wrote:
> On Tue, Jul 19, 2022 at 10:10:42AM +0800, Zhengchao Shao wrote:
>>
>> @@ -252,7 +252,7 @@ static int hpre_prepare_dma_buf(struct hpre_asym_request *hpre_req,
>> if (unlikely(shift < 0))
>> return -EINVAL;
>>
>> - ptr = dma_alloc_coherent(dev, ctx->key_sz, tmp, GFP_KERNEL);
>> + ptr = dma_alloc_coherent(dev, ctx->key_sz, tmp, flags);
>
> How about just using GFP_ATOMIC unconditinoally?
>
> Cheers,

Hi Herbert:
Thank you for your reply. I think differentiate the application
scenarios of GFP flags, which can be more suitable to allocate memory.

Zhengchao Shao

\
 
 \ /
  Last update: 2022-07-19 05:32    [W:0.121 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site