Messages in this thread | | | From | Bjorn Andersson <> | Subject | Re: (subset) [PATCH 4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() | Date | Mon, 18 Jul 2022 17:59:06 -0500 |
| |
On Sun, 1 May 2022 12:35:16 +0200, Krzysztof Kozlowski wrote: > The use of strncpy() is considered deprecated for NUL-terminated > strings[1]. Replace strncpy() with strscpy_pad(), to keep existing > pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: > glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: > > In function ‘qcom_glink_rx_close’, > inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: > drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); > > [...]
Applied, thanks!
[4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea
Best regards, -- Bjorn Andersson <bjorn.andersson@linaro.org>
| |