Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 19 Jul 2022 00:46:47 +0200 | Subject | Re: [PATCH v1 2/3] gpio: 74xx-mmio: Check MMIO_74XX_DIR_IN flag in mmio_74xx_dir_in() |
| |
On Tue, Jul 19, 2022 at 12:02 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> It's logically better to check the IN in ->direction_input() and > _OUT in ->direction_output(). > > While at it, replace ternary with plain if-conditional for the sake > of consistency with mmio_74xx_dir_out(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Yep this is better. Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |