Messages in this thread | | | Date | Mon, 18 Jul 2022 18:38:51 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] selftests/kprobe: Update test for no event name syntax error |
| |
On Mon, 18 Jul 2022 16:05:10 +0900 "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > The commit 208003254c32 ("selftests/kprobe: Do not test for GRP/ > without event failures") removed a syntax which is no more cause > a syntax error (NO_EVENT_NAME error with GRP/). > However, there are another case (NO_EVENT_NAME error without GRP/) > which causes a same error. This adds a test for that case. > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Queued. Thanks Masami!
-- Steve
> --- > .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > index 7c02509c71d0..9e85d3019ff0 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > @@ -21,6 +21,7 @@ check_error 'p:^/bar vfs_read' # NO_GROUP_NAME > check_error 'p:^12345678901234567890123456789012345678901234567890123456789012345/bar vfs_read' # GROUP_TOO_LONG > > check_error 'p:^foo.1/bar vfs_read' # BAD_GROUP_NAME > +check_error 'p:^ vfs_read' # NO_EVENT_NAME > check_error 'p:foo/^12345678901234567890123456789012345678901234567890123456789012345 vfs_read' # EVENT_TOO_LONG > check_error 'p:foo/^bar.1 vfs_read' # BAD_EVENT_NAME >
| |