Messages in this thread | | | From | Alex Deucher <> | Date | Mon, 18 Jul 2022 14:58:01 -0400 | Subject | Re: [PATCH 07/12] drm/amd/display: Remove unused value0 variable |
| |
On Thu, Jul 14, 2022 at 12:46 PM Maíra Canal <mairacanal@riseup.net> wrote: > > Remove the variable value0 from the function > dcn10_link_encoder_update_mst_stream_allocation_table. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:1223:11: > warning: variable 'value0' set but not used [-Wunused-but-set-variable] > uint32_t value0 = 0; > ^ > 1 warning generated. > > Signed-off-by: Maíra Canal <mairacanal@riseup.net> > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > index fbccb7263ad2..ea7d89bc293f 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > @@ -1220,7 +1220,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( > const struct link_mst_stream_allocation_table *table) > { > struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc); > - uint32_t value0 = 0; > uint32_t value1 = 0; > uint32_t value2 = 0; > uint32_t slots = 0; > @@ -1322,8 +1321,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( > do { > udelay(10); > > - value0 = REG_READ(DP_MSE_SAT_UPDATE); > -
There may be a reason to actually read the register here. @Wentland, Harry?
> REG_GET(DP_MSE_SAT_UPDATE, > DP_MSE_SAT_UPDATE, &value1); > > -- > 2.36.1 >
| |