lkml.org 
[lkml]   [2022]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] leds: clevo-mail: fix Kconfig "its" grammar
On Thu 2022-07-14 18:59:48, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction "it's"
> where appropriate.

Thank you, applied.

Hu. Hmm. Wow.

What is that? Kconfig describes very non-standard kernel interface,
and has several other typos in the it. I can fix the typos; but is
there someone still using this who would be willing to fix it?

Best regards,
Pavel
> @@ -456,7 +456,7 @@ config LEDS_CLEVO_MAIL
>
> The driver supports two kinds of interface: using ledtrig-timer
> or through /sys/class/leds/clevo::mail/brightness. As this LED
> - cannot change it's brightness it blinks instead. The brightness
> + cannot change its brightness it blinks instead. The brightness
> value 0 means off, 1..127 means blink at 0.5Hz and 128..255 means
> blink at 1Hz.
>

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index acd4f754c919..eaba0a8347fa 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -447,12 +447,12 @@ config LEDS_LP8860

config LEDS_CLEVO_MAIL
tristate "Mail LED on Clevo notebook"
- depends on LEDS_CLASS
+ depends on LEDS_CLASS && BROKEN
depends on X86 && SERIO_I8042 && DMI
help
This driver makes the mail LED accessible from userspace
- programs through the leds subsystem. This LED have three
- known mode: off, blink at 0.5Hz and blink at 1Hz.
+ programs through the LEDs subsystem. This LED has three
+ known modes: off, blink at 0.5Hz and blink at 1Hz.

The driver supports two kinds of interface: using ledtrig-timer
or through /sys/class/leds/clevo::mail/brightness. As this LED
--
People of Russia, stop Putin before his war on Ukraine escalates.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-07-17 12:23    [W:0.122 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site