Messages in this thread |  | | Date | Mon, 18 Jul 2022 10:32:40 +0800 | Subject | Re: [PATCH v2] sched/fair: Remove unused parameter idle of _nohz_idle_balance() | From | Hao Jia <> |
| |
gentle ping.
On 2022/7/10 Hao Jia wrote: > Commit 7a82e5f52a35 ("sched/fair: Merge for each idle cpu loop of ILB") > has been merged. The parameter idle of _nohz_idle_balance() > is not used anymore so we can remove it. > > Signed-off-by: Hao Jia <jiahao.os@bytedance.com> > Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Hi Peter, The patch got Reviewed-by from Vincent. If you have time, please review the patch.
Regards, Hao
> --- > kernel/sched/fair.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 77b2048a9326..8d4be2a95e37 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -10682,8 +10682,7 @@ static bool update_nohz_stats(struct rq *rq) > * can be a simple update of blocked load or a complete load balance with > * tasks movement depending of flags. > */ > -static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags, > - enum cpu_idle_type idle) > +static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags) > { > /* Earliest time when we have to do rebalance again */ > unsigned long now = jiffies; > @@ -10798,7 +10797,7 @@ static bool nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle) > if (idle != CPU_IDLE) > return false; > > - _nohz_idle_balance(this_rq, flags, idle); > + _nohz_idle_balance(this_rq, flags); > > return true; > } > @@ -10818,7 +10817,7 @@ void nohz_run_idle_balance(int cpu) > * (ie NOHZ_STATS_KICK set) and will do the same. > */ > if ((flags == NOHZ_NEWILB_KICK) && !need_resched()) > - _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK, CPU_IDLE); > + _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK); > } > > static void nohz_newidle_balance(struct rq *this_rq)
|  |