lkml.org 
[lkml]   [2022]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] leds: max597x: Add support for max597x
Hi!

> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index a49979f41eee..682748097276 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -598,6 +598,16 @@ config LEDS_ADP5520
> To compile this driver as a module, choose M here: the module will
> be called leds-adp5520.
>
> +config LEDS_MAX597X
> + tristate "Maxim 597x leds"
> + depends on I2C
> + depends on OF
> + depends on LEDS_CLASS
> + select MFD_MAX597X
> + help
> + This driver controls a Maxim 5970/5978 indication led via I2C bus.
> + The MAX5970/5978 is a smart switch with 4 indication leds

led->LED.

Add "to compile this driver as a module, choose M here: the module will
be called ..".

Add "." at end of sentence.

> +++ b/drivers/leds/leds-max597x.c
> @@ -0,0 +1,130 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device driver for regulators in MAX5970 and MAX5978 IC

?

> +static int max597x_led_set_brightness(struct led_classdev *cdev,
> + enum led_brightness brightness)
> +{
> + struct max597x_led *led = cdev->driver_data;
> + int ret;
> +
> + if (!led || !led->regmap)
> + return -1;

-ERRNO.

> +static int max597x_led_probe(struct platform_device *pdev)
> +{
> +
> +
> + struct max597x_data *max597x = dev_get_drvdata(pdev->dev.parent);
> + struct device_node *np = dev_of_node(pdev->dev.parent);

Delete empty lines.

> + struct device_node *led_node;
> + struct device_node *child;
> + int ret = 0;
> +
> +

One empty line would be enough.

> +module_platform_driver(max597x_led_driver);
> +
> +
> +MODULE_AUTHOR("Patrick Rudolph <patrick.rudolph@9elements.com>");

One empty line would be enough.

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-07-17 14:43    [W:0.120 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site