lkml.org 
[lkml]   [2022]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 2/4] drm/format-helper: Rename test cases to make them more generic
    On Sat, Jul 9, 2022 at 7:58 PM José Expósito <jose.exposito89@gmail.com> wrote:
    >
    > The tests available at the moment only check the conversion from
    > XRGB8888 to RGB332. However, more conversions will be tested in the
    > future.
    >
    > In order to make the struct and functions present in the tests more
    > generic, rename xrgb8888_to_rgb332_* to convert_xrgb8888_*.
    >
    > Tested-by: Tales L. Aparecida <tales.aparecida@gmail.com>
    > Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
    > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    > ---

    Looks good to me from the KUnit point of view.

    Reviewed-by: David Gow <davidgow@google.com>

    Cheers,
    -- David


    > drivers/gpu/drm/tests/drm_format_helper_test.c | 17 ++++++++---------
    > 1 file changed, 8 insertions(+), 9 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
    > index 4d074c2e48bf..f66aaa0e52c9 100644
    > --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
    > +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
    > @@ -16,7 +16,7 @@
    >
    > #define TEST_BUF_SIZE 50
    >
    > -struct xrgb8888_to_rgb332_case {
    > +struct convert_xrgb8888_case {
    > const char *name;
    > unsigned int pitch;
    > unsigned int dst_pitch;
    > @@ -25,7 +25,7 @@ struct xrgb8888_to_rgb332_case {
    > const u8 expected[4 * TEST_BUF_SIZE];
    > };
    >
    > -static struct xrgb8888_to_rgb332_case xrgb8888_to_rgb332_cases[] = {
    > +static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
    > {
    > .name = "single_pixel_source_buffer",
    > .pitch = 1 * 4,
    > @@ -126,18 +126,18 @@ static u32 *le32buf_to_cpu(struct kunit *test, const u32 *buf, size_t buf_size)
    > return dst;
    > }
    >
    > -static void xrgb8888_to_rgb332_case_desc(struct xrgb8888_to_rgb332_case *t,
    > - char *desc)
    > +static void convert_xrgb8888_case_desc(struct convert_xrgb8888_case *t,
    > + char *desc)
    > {
    > strscpy(desc, t->name, KUNIT_PARAM_DESC_SIZE);
    > }
    >
    > -KUNIT_ARRAY_PARAM(xrgb8888_to_rgb332, xrgb8888_to_rgb332_cases,
    > - xrgb8888_to_rgb332_case_desc);
    > +KUNIT_ARRAY_PARAM(convert_xrgb8888, convert_xrgb8888_cases,
    > + convert_xrgb8888_case_desc);
    >
    > static void xrgb8888_to_rgb332_test(struct kunit *test)
    > {
    > - const struct xrgb8888_to_rgb332_case *params = test->param_value;
    > + const struct convert_xrgb8888_case *params = test->param_value;
    > size_t dst_size;
    > __u8 *dst = NULL;
    > __u32 *src = NULL;
    > @@ -163,8 +163,7 @@ static void xrgb8888_to_rgb332_test(struct kunit *test)
    > }
    >
    > static struct kunit_case drm_format_helper_test_cases[] = {
    > - KUNIT_CASE_PARAM(xrgb8888_to_rgb332_test,
    > - xrgb8888_to_rgb332_gen_params),
    > + KUNIT_CASE_PARAM(xrgb8888_to_rgb332_test, convert_xrgb8888_gen_params),
    > {}
    > };
    >
    > --
    > 2.25.1
    >
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2022-07-16 11:35    [W:3.077 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site