lkml.org 
[lkml]   [2022]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: supply: Fix typo in power_supply_check_supplies
Hi,

On Tue, Jul 05, 2022 at 11:32:44AM +0800, Schspa Shi wrote:
> It seems to be a typo, there is no actual BUG, but it's better to
> fix it to avoid any possible BUG after we change the type of
> supplied_from.
>
> Signed-off-by: Schspa Shi <schspa@gmail.com>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/power_supply_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index fad5890c899e..02228d68c599 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -263,13 +263,13 @@ static int power_supply_check_supplies(struct power_supply *psy)
> return 0;
>
> /* All supplies found, allocate char ** array for filling */
> - psy->supplied_from = devm_kzalloc(&psy->dev, sizeof(psy->supplied_from),
> + psy->supplied_from = devm_kzalloc(&psy->dev, sizeof(*psy->supplied_from),
> GFP_KERNEL);
> if (!psy->supplied_from)
> return -ENOMEM;
>
> *psy->supplied_from = devm_kcalloc(&psy->dev,
> - cnt - 1, sizeof(char *),
> + cnt - 1, sizeof(**psy->supplied_from),
> GFP_KERNEL);
> if (!*psy->supplied_from)
> return -ENOMEM;
> --
> 2.29.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-07-17 00:48    [W:0.039 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site