lkml.org 
[lkml]   [2022]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios
    On Saturday 16 July 2022 16:40:28 Uwe Kleine-König wrote:
    > On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Rohár wrote:
    > > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre-XP
    > > variants like Armada 370 do not support per CPU interrupts for gpios.
    > >
    > > So change compatible string for Armada 38x from "marvell,armada-370-gpio"
    > > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indicates
    > > XP variant or new.
    > >
    > > Driver gpio-mvebu.c which handles both pre-XP and XP variants already
    > > provides support for per CPU interrupts on XP and newer variants.
    > >
    > > Signed-off-by: Pali Rohár <pali@kernel.org>
    > > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-38x")
    > > ---
    > > arch/arm/boot/dts/armada-38x.dtsi | 4 ++--
    > > 1 file changed, 2 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
    > > index df3c8d1d8f64..9343de6947b3 100644
    > > --- a/arch/arm/boot/dts/armada-38x.dtsi
    > > +++ b/arch/arm/boot/dts/armada-38x.dtsi
    > > @@ -292,7 +292,7 @@
    > > };
    > >
    > > gpio0: gpio@18100 {
    > > - compatible = "marvell,armada-370-gpio",
    > > + compatible = "marvell,armadaxp-gpio",
    > > "marvell,orion-gpio";
    >
    > If you can treat the XP variant as 370 and everything that is supposed
    > to work on 370 works then, then maybe the right incarnation is:
    >
    > compatible = "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "marvell,orion-gpio";
    >
    > ?

    For pre-XP variants is "marvell,orion-gpio" enough and for XP + post-XP
    is needed "marvell,armadaxp-gpio" (with possible "marvell,orion-gpio"
    for backward compatibility).

    So I do not see reason why to add "marvell,armada-370-gpio" nor what
    value it brings.

    > Best regards
    > Uwe
    >
    > --
    > Pengutronix e.K. | Uwe Kleine-König |
    > Industrial Linux Solutions | https://www.pengutronix.de/ |


    \
     
     \ /
      Last update: 2022-07-16 16:52    [W:8.431 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site