lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] ads7846: don't report pressure for ads7845
From
On 14/07/2022 13:32, Andy Shevchenko wrote:
> On Thu, Jul 14, 2022 at 10:43:17AM +0200, Luca Ellero wrote:
>> From: Luca Ellero <l.ellero@asem.it>
>>
>> ADS7845 doesn't support pressure.
>> This patch avoids the following error reported by libinput-list-devices:
>> "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE"
>
> Missed period, otherwise looks good.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>> Signed-off-by: Luca Ellero <l.ellero@asem.it>
>> ---
>> drivers/input/touchscreen/ads7846.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index bed68a68f330..24605c40d039 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -1316,8 +1316,9 @@ static int ads7846_probe(struct spi_device *spi)
>> pdata->y_min ? : 0,
>> pdata->y_max ? : MAX_12BIT,
>> 0, 0);
>> - input_set_abs_params(input_dev, ABS_PRESSURE,
>> - pdata->pressure_min, pdata->pressure_max, 0, 0);
>> + if (ts->model != 7845)
>> + input_set_abs_params(input_dev, ABS_PRESSURE,
>> + pdata->pressure_min, pdata->pressure_max, 0, 0);
>>
>> /*
>> * Parse common framework properties. Must be done here to ensure the
>> --
>> 2.25.1
>>
>

Hi Andy,
thank you for your comments.
I will resend v2 of the patches.
Regards
Luca

--
Luca Ellero

E-mail: luca.ellero@brickedbrain.com
Internet: www.brickedbrain.com

\
 
 \ /
  Last update: 2022-07-15 16:40    [W:0.059 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site