Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 15 Jul 2022 15:05:40 +0200 | Subject | Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support |
| |
On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto:
...
> > +#define STATE_OFF 0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > > enum mt6370_state { > STATE_OFF = 0, > STATE_KEEP, > STATE_ON,
> STATE_MAX,
Usually we don't put commas at the terminator entries.
> };
-- With Best Regards, Andy Shevchenko
| |