lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH] mmc: sdhci-of-aspeed: test: Fix dependencies when KUNIT=m
    From
    While the sdhci-of-aspeed KUnit tests do work when builtin, and do work
    when KUnit itself is being built as a module, the two together break.

    This is because the KUnit tests (understandably) depend on KUnit, so a
    built-in test cannot build if KUnit is a module.

    Fix this by adding a dependency on (MMC_SDHCI_OF_ASPEED=m || KUNIT=y),
    which only excludes this one problematic configuration.

    This was reported on a nasty openrisc-randconfig run by the kernel test
    robot, though for some reason (compiler optimisations removing the test
    code?) I wasn't able to reproduce it locally on x86:
    https://lore.kernel.org/linux-mm/202207140122.fzhlf60k-lkp@intel.com/T/

    Fixes: 291cd54e5b05 ("mmc: sdhci-of-aspeed: test: Use kunit_test_suite() macro")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: David Gow <davidgow@google.com>
    ---
    drivers/mmc/host/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
    index 10c563999d3d..e63608834411 100644
    --- a/drivers/mmc/host/Kconfig
    +++ b/drivers/mmc/host/Kconfig
    @@ -171,6 +171,7 @@ config MMC_SDHCI_OF_ASPEED
    config MMC_SDHCI_OF_ASPEED_TEST
    bool "Tests for the ASPEED SDHCI driver" if !KUNIT_ALL_TESTS
    depends on MMC_SDHCI_OF_ASPEED && KUNIT
    + depends on (MMC_SDHCI_OF_ASPEED=m || KUNIT=y)
    default KUNIT_ALL_TESTS
    help
    Enable KUnit tests for the ASPEED SDHCI driver. Select this
    --
    2.37.0.170.g444d1eabd0-goog
    \
     
     \ /
      Last update: 2022-07-15 06:04    [W:5.838 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site