lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH bpf-next v6 12/23] HID: initial BPF implementation
    On Tue, Jul 12, 2022 at 04:58:39PM +0200, Benjamin Tissoires wrote:
    > --- /dev/null
    > +++ b/drivers/hid/bpf/Kconfig
    > @@ -0,0 +1,19 @@
    > +# SPDX-License-Identifier: GPL-2.0-only
    > +menu "HID-BPF support"
    > + #depends on x86_64
    > +
    > +config HID_BPF
    > + bool "HID-BPF support"
    > + default y

    Things are only default y if you can't boot your machine without it.
    Perhaps just mirror what HID is to start with and do not select HID?

    > + depends on BPF && BPF_SYSCALL
    > + select HID

    select is rough, why not depend?


    thanks,

    greg k-

    \
     
     \ /
      Last update: 2022-07-15 07:03    [W:3.291 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site