lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] Bluetooth: hci_sync: Remove redundant func definition
From
On 7/15/2022 3:34 PM, Paul Menzel wrote:
> Dear Zijun,
>
>
> Thank you for the patch.
>
> Am 15.07.22 um 06:14 schrieb Zijun Hu:
>> both hci_request.c and hci_sync.c have the same definition
>> for disconnected_accept_list_entries(), so remove a redundant
>> copy.
>
> Please use 75 characters per line for Linux commit message bodies. That way, only two instead of three lines are needed.
thanks for your suggestion, correct within v4 sent. could you code review again?
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>> v1->v2
>>     -remove the func copy within hci_request.c instead of hci_sync.c
>>   net/bluetooth/hci_request.c | 18 ------------------
>>   net/bluetooth/hci_request.h |  2 ++
>>   net/bluetooth/hci_sync.c    |  2 +-
>>   3 files changed, 3 insertions(+), 19 deletions(-)
>
> […]
>
>
> Kind regards,
>
> Paul

\
 
 \ /
  Last update: 2022-07-15 09:48    [W:0.042 / U:1.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site