Messages in this thread | | | Date | Fri, 15 Jul 2022 15:45:31 +0800 | From | Yue Hu <> | Subject | Re: [PATCH 05/16] erofs: drop the old pagevec approach |
| |
On Fri, 15 Jul 2022 15:19:46 +0800 Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> On Fri, Jul 15, 2022 at 03:07:37PM +0800, Yue Hu wrote: > > On Thu, 14 Jul 2022 21:20:40 +0800 > > Gao Xiang <hsiangkao@linux.alibaba.com> wrote: > > > > > Remove the old pagevec approach but keep z_erofs_page_type for now. > > > It will be reworked in the following commits as well. > > > > > > Also rename Z_EROFS_NR_INLINE_PAGEVECS as Z_EROFS_INLINE_BVECS with > > > the new value 2 since it's actually enough to bootstrap. > > > > I notice there are 2 comments as below which still use pagevec, should we > > update it as well? > > > > [1] > > * pagevec) since it can be directly decoded without I/O submission. > > [2] > > * for inplace I/O or pagevec (should be processed in strict order.) > > Yeah, thanks for reminder... I will update it in this patch in the next > version. > > > > > BTW, utils.c includes needles <pagevec.h>, we can remove it along with the patchset > > or remove it later. > > That is a completely different stuff, would you mind submitting a patch > to remove it if needed?
ok, may submit later.
> > Thanks, > Gao Xiang
| |