Messages in this thread | | | Date | Thu, 14 Jul 2022 21:38:57 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI |
| |
On Fri, 15 Jul 2022 12:21:31 +0800 Sieng-Piaw Liew wrote: > Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular > netif_napi_add() function. > > Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
Please use netif_napi_add_tx(), since you use the default weight anyway there's no need to specify it.
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index 948584761e66..bf293a3ed4c9 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > @@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > netif_napi_add(netdev, &adapter->rrd_ring[i].napi, > atl1c_clean_rx, 64); > for (i = 0; i < adapter->tx_queue_count; ++i) > - netif_napi_add(netdev, &adapter->tpd_ring[i].napi, > - atl1c_clean_tx, 64); > + netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi, > + atl1c_clean_tx, 64); > timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0); > /* setup the private structure */ > err = atl1c_sw_init(adapter);
| |