lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break characters
Am 2022-07-15 04:59, schrieb Sherry Sun:
> The LPUART can't distinguish between a break signal and a framing
> error,
> so need to count the break characters if there is a framing error and
> received data is zero instead of the parity error.

Ah, it seems I mixed up the framing and the partiy error. Did you test
the break in the receive path, though?

-michael

>
> Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq
> work")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c
> b/drivers/tty/serial/fsl_lpuart.c
> index fc7d235a1e27..b6365566a460 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port
> *sport)
>
> if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) {
> if (sr & UARTSTAT_PE) {
> + sport->port.icount.parity++;
> + } else if (sr & UARTSTAT_FE) {
> if (is_break)
> sport->port.icount.brk++;
> else
> - sport->port.icount.parity++;
> - } else if (sr & UARTSTAT_FE) {
> - sport->port.icount.frame++;
> + sport->port.icount.frame++;
> }
>
> if (sr & UARTSTAT_OR)
> @@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port
> *sport)
> sr &= sport->port.read_status_mask;
>
> if (sr & UARTSTAT_PE) {
> + flg = TTY_PARITY;
> + } else if (sr & UARTSTAT_FE) {
> if (is_break)
> flg = TTY_BREAK;
> else
> - flg = TTY_PARITY;
> - } else if (sr & UARTSTAT_FE) {
> - flg = TTY_FRAME;
> + flg = TTY_FRAME;
> }
>
> if (sr & UARTSTAT_OR)

--
-michael

\
 
 \ /
  Last update: 2022-07-15 09:00    [W:0.106 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site