lkml.org 
[lkml]   [2022]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v10 1/2] thermal: Add thermal driver for Sunplus
From
On 14/07/2022 07:32, Lh Kuo 郭力豪 wrote:
>>> +}
>>> +
>>> +static int sunplus_thermal_remove(struct platform_device *pdev) {
>>> + struct sp_thermal_data *sp_data = platform_get_drvdata(pdev);
>>> +
>>> + thermal_zone_of_sensor_unregister(&pdev->dev, sp_data->pcb_tz);
>>
>> You used devm to register, so this looks wrong and will lead to double free.
>>
>>
>
> You mean the remove function is not needed. ??

At least this call but after its removal the entire function would be
empty, I think.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-14 08:51    [W:0.048 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site