Messages in this thread | | | From | Tim Van Patten <> | Date | Thu, 14 Jul 2022 12:17:36 -0600 | Subject | Re: [PATCH] platform/chrome: cros_ec: Send host event for prepare/complete |
| |
[Resending in plain text mode.]
Hi Guenter,
The PM subsystem doesn't print out the prepare/complete callbacks, so we've added them to keep parity with the rest of the system that has this output.
On Fri, Jul 1, 2022 at 3:16 PM Tim Van Patten <timvp@google.com> wrote: > > Hi Guenter, > > The PM subsystem doesn't print out the prepare/complete callbacks, so we've added them to keep parity with the rest of the system that has this output. > > On Fri, Jul 1, 2022 at 2:40 PM kernel test robot <lkp@intel.com> wrote: >> >> Hi Tim, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on chrome-platform/for-next] >> [also build test ERROR on linus/master v5.19-rc4 next-20220701] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Tim-Van-Patten/platform-chrome-cros_ec-Send-host-event-for-prepare-complete/20220701-235602 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next >> config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220702/202207020433.aSSwzWJn-lkp@intel.com/config) >> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 >> reproduce (this is a W=1 build): >> # https://github.com/intel-lab-lkp/linux/commit/46055ab1171506ae76daf77f7b880087c8a9119f >> git remote add linux-review https://github.com/intel-lab-lkp/linux >> git fetch --no-tags linux-review Tim-Van-Patten/platform-chrome-cros_ec-Send-host-event-for-prepare-complete/20220701-235602 >> git checkout 46055ab1171506ae76daf77f7b880087c8a9119f >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot <lkp@intel.com> >> >> All errors (new ones prefixed by >>): >> >> >> drivers/platform/chrome/cros_ec_lpc.c:553:20: error: 'cros_ec_lpc_suspend' undeclared here (not in a function); did you mean 'cros_ec_suspend'? >> 553 | .prepare = cros_ec_lpc_suspend, >> | ^~~~~~~~~~~~~~~~~~~ >> | cros_ec_suspend >> >> drivers/platform/chrome/cros_ec_lpc.c:554:21: error: 'cros_ec_lpc_resume' undeclared here (not in a function); did you mean 'cros_ec_lpc_remove'? >> 554 | .complete = cros_ec_lpc_resume >> | ^~~~~~~~~~~~~~~~~~ >> | cros_ec_lpc_remove >> >> >> vim +553 drivers/platform/chrome/cros_ec_lpc.c >> >> 551 >> 552 static const struct dev_pm_ops cros_ec_lpc_pm_ops = { >> > 553 .prepare = cros_ec_lpc_suspend, >> > 554 .complete = cros_ec_lpc_resume >> 555 }; >> 556 >> >> -- >> 0-DAY CI Kernel Test Service >> https://01.org/lkp > > > > -- > > Tim Van Patten | ChromeOS | timvp@google.com | (720) 432-0997
--
Tim Van Patten | ChromeOS | timvp@google.com | (720) 432-0997
| |