lkml.org 
[lkml]   [2022]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 8/8] PCI: qcom: Sort device-id table
    On Thu, Jul 14, 2022 at 09:13:48AM +0200, Johan Hovold wrote:
    > Sort the device-id table entries alphabetically by compatible string to
    > make it easier to find entries and add new ones.
    >
    > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    > ---
    > drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
    > index 8dddb72f8647..fea921cca8fa 100644
    > --- a/drivers/pci/controller/dwc/pcie-qcom.c
    > +++ b/drivers/pci/controller/dwc/pcie-qcom.c
    > @@ -1749,24 +1749,24 @@ static int qcom_pcie_remove(struct platform_device *pdev)
    > }
    >
    > static const struct of_device_id qcom_pcie_match[] = {
    > + { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 },
    > { .compatible = "qcom,pcie-apq8084", .data = &cfg_1_0_0 },
    > + { .compatible = "qcom,pcie-ipq6018", .data = &cfg_2_9_0 },
    > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 },
    > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 },
    > - { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 },
    > - { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
    > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 },
    > { .compatible = "qcom,pcie-ipq4019", .data = &cfg_2_4_0 },

    qcom,pcie-ipq4019 should be moved up above qcom,pcie-ipq6018.

    Brian

    \
     
     \ /
      Last update: 2022-07-14 16:29    [W:3.118 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site