Messages in this thread | | | Date | Wed, 13 Jul 2022 20:21:07 +0530 | Subject | Re: [PATCH] soundwire: qcom: Update error prints to debug prints | From | Srinivasa Rao Mandadapu <> |
| |
On 7/13/2022 7:26 PM, Andrew Halaney wrote: Thanks for your time Andrew. > A couple of drive by nits: > > On Wed, Jul 13, 2022 at 05:52:01PM +0530, Srinivasa Rao Mandadapu wrote: >> Upadte error prints to debug prints to avoid redundant logging in kernel >> boot time, as these prints are informative prints in irq handler. > s/Upadte/Update/ Okay. Will fix it. > >> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> >> --- >> drivers/soundwire/qcom.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index 9df970e..a4293d0 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) >> break; >> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: >> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: >> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", >> - __func__); >> + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__); > There's no need for __func__ usage with dev_dbg() when giving +f flag > when enabling adds this for you! Okay. Will remove __func__ and change dev_dbg() to dev_dbg_ratelimited(). > > With those changes feel free to add: > > Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > > Thanks, > Andrew > >> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status); >> if (swrm->slave_status == slave_status) { >> - dev_err(swrm->dev, "Slave status not changed %x\n", >> + dev_dbg(swrm->dev, "Slave status not changed %x\n", >> slave_status); >> } else { >> qcom_swrm_get_device_status(swrm); >> -- >> 2.7.4 >>
| |