Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 13 Jul 2022 13:24:33 +0200 | Subject | Re: [PATCH 4/6] gpiolib: cdev: simplify line event identification |
| |
On Wed, Jul 13, 2022 at 12:27 PM Kent Gibson <warthog618@gmail.com> wrote: > On Wed, Jul 13, 2022 at 11:59:10AM +0200, Andy Shevchenko wrote: > > On Wed, Jul 13, 2022 at 3:39 AM Kent Gibson <warthog618@gmail.com> wrote:
...
> > > + le.id = level ? GPIO_V2_LINE_EVENT_RISING_EDGE : > > > + GPIO_V2_LINE_EVENT_FALLING_EDGE; > > > > It seems several times you are doing the same, perhaps a helper? > > If by several times you mean twice, then yeah. > Not sure that reaches the threshold for a helper though.
Up to you, then!
-- With Best Regards, Andy Shevchenko
| |