Messages in this thread | | | Subject | Re: [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code | From | Li Huafei <> | Date | Wed, 13 Jul 2022 19:21:50 +0800 |
| |
On 2022/7/12 21:34, Mark Brown wrote: > On Tue, Jul 12, 2022 at 10:15:26AM +0800, Li Huafei wrote: > >> In order to use generic arch_stack_walk() code, make stack walk callback >> consistent with it. > It might be useful to say what the changes are here, if nothing else > that makes it easier to review and confirm that the changes are doing > what you intend them to. See my conversion for arm64 for an example.
Thanks for the advice. I've looked at the commit:
baa2cd417053 ("arm64: stacktrace: Make stack walk callback consistent with generic code")
The description is very clear. It describes the change in detail and gives a reason for making that change a separate commit. The same description applies to the current changes, so I took the commit message directly, just made the s/arm64/ARM/ changes, and updated to v2:
https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/
> The actual changes here seem OK though > > Reviewed-by: Mark Brown <broonie@kernel.org>
Thanks for the review!
Thanks,
Huafei
| |