Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 13 Jul 2022 12:19:03 +0200 | Subject | Re: [PATCH] serial: 8250_dw: Avoid pslverr on reading empty receiver fifo |
| |
On Wed, Jul 13, 2022 at 10:13 AM VAMSHI GAJJELA <vamshigajjela@google.com> wrote: > On Tue, Jul 12, 2022 at 6:56 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Tue, Jul 12, 2022 at 3:16 PM Vamshi Gajjela <vamshigajjela@google.com> wrote:
...
> > > + lsr = p->serial_in(p, UART_LSR); > > > > The only caller of this function already has the lsr value, why you > > can't (re)use it? > lsr is not read before, caller function (dw8250_check_lcr) reads lcr.
I see, thanks for elaboration.
-- With Best Regards, Andy Shevchenko
| |