lkml.org 
[lkml]   [2022]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] serial: 8250_dw: Avoid pslverr on reading empty receiver fifo
On Wed, Jul 13, 2022 at 10:13 AM VAMSHI GAJJELA
<vamshigajjela@google.com> wrote:
> On Tue, Jul 12, 2022 at 6:56 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Jul 12, 2022 at 3:16 PM Vamshi Gajjela <vamshigajjela@google.com> wrote:

...

> > > + lsr = p->serial_in(p, UART_LSR);
> >
> > The only caller of this function already has the lsr value, why you
> > can't (re)use it?
> lsr is not read before, caller function (dw8250_check_lcr) reads lcr.

I see, thanks for elaboration.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-07-13 12:21    [W:0.063 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site