Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 13 Jul 2022 12:03:07 +0200 | Subject | Re: [PATCH 6/6] gpiolib: cdev: compile out HTE unless CONFIG_HTE selected |
| |
On Wed, Jul 13, 2022 at 3:39 AM Kent Gibson <warthog618@gmail.com> wrote: > > The majority of builds do not include HTE, so compile out hte > functionality unless CONFIG_HTE is selected.
...
> +#ifdef CONFIG_HTE > /* > * -- hte specific fields -- > */
Now this comment seems useless to me and it takes 3 LoCs.
...
> + else if (IS_ENABLED(CONFIG_HTE) && > + (test_bit(FLAG_EVENT_CLOCK_HTE, &line->desc->flags)))
Too many parentheses.
...
> + if (!IS_ENABLED(CONFIG_HTE) || > + !test_bit(FLAG_EVENT_CLOCK_HTE, &line->desc->flags)) {
if (!(x && y)) ?
...
> + if (!IS_ENABLED(CONFIG_HTE) && > + (flags & GPIO_V2_LINE_FLAG_EVENT_CLOCK_HTE)) > + return -EOPNOTSUPP;
Ditto for consistency?
-- With Best Regards, Andy Shevchenko
| |