Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 13 Jul 2022 11:59:10 +0200 | Subject | Re: [PATCH 4/6] gpiolib: cdev: simplify line event identification |
| |
On Wed, Jul 13, 2022 at 3:39 AM Kent Gibson <warthog618@gmail.com> wrote: > > Reorganise line event identification code to reduce code duplication, > and replace if-else initializers with the ternary equivalent to > improve readability.
...
> + le.id = level ? GPIO_V2_LINE_EVENT_RISING_EDGE : > + GPIO_V2_LINE_EVENT_FALLING_EDGE;
It seems several times you are doing the same, perhaps a helper?
-- With Best Regards, Andy Shevchenko
| |