Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next] octeontx2-af: fix error return code in rvu_npc_exact_init() | Date | Wed, 13 Jul 2022 17:56:00 +0800 |
| |
If rvu_npc_exact_save_drop_rule_chan_and_mask() returns false, the 'err' is uninitialized, return -EINVAL instead.
Fixes: c6238bc0614d ("octeontx2-af: Drop rules for NPC MCAM") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c index ed8b9afbf731..563bf1497fd0 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c @@ -1961,7 +1961,7 @@ int rvu_npc_exact_init(struct rvu *rvu) dev_err(rvu->dev, "%s: failed to set drop info for cgx=%d, lmac=%d, chan=%llx\n", __func__, cgx_id, lmac_id, chan_val); - return err; + return -EINVAL; } err = npc_install_mcam_drop_rule(rvu, *drop_mcam_idx, -- 2.25.1
| |