lkml.org 
[lkml]   [2022]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
Date
> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
>
> On 13/07/2022 11:03, Peng Fan wrote:
> > Hi Krzysztof,
> >
> >> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu
> >> blk ctrl
> >>
> >> On 13/07/2022 08:36, Peng Fan (OSS) wrote:
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> >>> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
> >>>
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> ---
> >>> .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml | 93 ++++++++++++++++---
> >>> include/dt-bindings/power/imx8mp-power.h | 4 +
> >>> 2 files changed, 86 insertions(+), 11 deletions(-)
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml
> >>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml index 26487daa64d9..d05930f61f95 100644
> >>> ---
> >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml
> >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-
> blk-
> >> ctr
> >>> +++ l.yaml
> >>> @@ -28,24 +28,15 @@ properties:
> >>>
> >>> power-domains:
> >>> minItems: 4
> >>> - maxItems: 4
> >>
> >> This is not correct. maxItems must stay, but you could drop minItems,
> >> prefferrably in separate patch.
> > [Peng Fan]
> >
> > Ok, I will only keep maxItems. For separate patch, you mean separate
> > adding description for i.MX8MM to one patch, right?
>
> I mean, a new patch doing cleanup. You currently have minItems and
> maxItems set as the same value. In such case minItems is not necessary.
> You could remove all of minItems (when equal to maxItems) before adding
> new device support.

Thanks, got it. I will wait for a few days to collect comments on other
parts before V3.

Thanks,
Peng.
>
>
> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2022-07-13 11:16    [W:0.051 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site