Messages in this thread | | | Date | Wed, 13 Jul 2022 10:29:22 +0200 | Subject | Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl | From | Krzysztof Kozlowski <> |
| |
On 13/07/2022 08:36, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse > the i.MX8MM VPU blk ctrl yaml file. And add description for the items. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml | 93 ++++++++++++++++--- > include/dt-bindings/power/imx8mp-power.h | 4 + > 2 files changed, 86 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > index 26487daa64d9..d05930f61f95 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > @@ -28,24 +28,15 @@ properties: > > power-domains: > minItems: 4 > - maxItems: 4
This is not correct. maxItems must stay, but you could drop minItems, prefferrably in separate patch.
> > power-domain-names: > - items: > - - const: bus > - - const: g1 > - - const: g2 > - - const: h1 > + minItems: 4
maxItems instead
> > clocks: > minItems: 3 > - maxItems: 3
Same error...
Best regards, Krzysztof
| |