Messages in this thread | | | Subject | Re: [PATCH] Revert "spi: simplify devm_spi_register_controller" | From | Yang Yingliang <> | Date | Thu, 14 Jul 2022 10:08:31 +0800 |
| |
On 2022/7/13 20:42, Mark Brown wrote: > On Tue, Jul 12, 2022 at 09:55:04PM +0800, Yang Yingliang wrote: >> This reverts commit 59ebbe40fb51e307032ae7f63b2749fad2d4635a. >> >> If devm_add_action() fails in devm_add_action_or_reset(), >> devm_spi_unregister() will be called, it decreases the > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. > > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. OK. Thanks for changing the subject to apply it, I will make my patch more readable next time.
Thanks, Yang
| |