Messages in this thread | | | From | Stanislav Fomichev <> | Date | Wed, 13 Jul 2022 16:01:55 -0700 | Subject | Re: [PATCH bpf-next] libbpf: Add bpf_map__set_name() |
| |
On Wed, Jul 13, 2022 at 3:32 PM Joe Burton <jevburton@google.com> wrote: > > > Asked you internally, but not sure I follow. Can you share more on why > > the following won't fix it for us: > > > > https://lore.kernel.org/bpf/OSZP286MB1725CEA1C95C5CB8E7CCC53FB8869@OSZP286MB1725.JPNP286.PROD.OUTLOOK.COM/ > > > > ? > > > > The idea seems to be to get the supplied map name (from the obj) > > instead of using pin name? So why is it not enough? > > You're correct, this approach also resolves the issue. No need for this > new API.
SG! New helper might still be useful, but I'm not sure how safe that is, given how much we use the name internally in libbpf (name/pin_path). So it might be safer to use Anquan's approach for now.
Andrii, any concerns with [1] ? Should we pull that in?
[1] https://lore.kernel.org/bpf/OSZP286MB1725CEA1C95C5CB8E7CCC53FB8869@OSZP286MB1725.JPNP286.PROD.OUTLOOK.COM/
| |