Messages in this thread | | | Date | Wed, 13 Jul 2022 18:00:59 -0400 | From | Rodrigo Vivi <> | Subject | Re: [PATCH v2 01/39] drm/i915/gvt: Fix kernel-doc for intel_gvt_switch_mmio() |
| |
On Wed, Jul 13, 2022 at 05:54:44PM -0400, Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:11:49AM +0100, Mauro Carvalho Chehab wrote: > > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > > Fix the following W=1 kernel warnings: > > > > drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting > > prototype for intel_gvt_switch_render_mmio(). Prototype was for > > intel_gvt_switch_mmio() instead. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
I actually changed my mind after seeing that in most cases you use "()" for the functions and you didn't use for this case...
which one should we pick for consistency?
> > > --- > > > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ > > > > drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gvt/mmio_context.c b/drivers/gpu/drm/i915/gvt/mmio_context.c > > index c85bafe7539e..1c6e941c9666 100644 > > --- a/drivers/gpu/drm/i915/gvt/mmio_context.c > > +++ b/drivers/gpu/drm/i915/gvt/mmio_context.c > > @@ -546,7 +546,7 @@ static void switch_mmio(struct intel_vgpu *pre, > > } > > > > /** > > - * intel_gvt_switch_render_mmio - switch mmio context of specific engine > > + * intel_gvt_switch_mmio - switch mmio context of specific engine > > * @pre: the last vGPU that own the engine > > * @next: the vGPU to switch to > > * @engine: the engine > > -- > > 2.36.1 > >
| |