Messages in this thread | | | From | <> | Subject | Re: [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support | Date | Wed, 13 Jul 2022 21:10:28 +0000 |
| |
On Wed, 2022-07-13 at 19:50 +0200, Andy Shevchenko wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Jul 13, 2022 at 7:44 PM <Conor.Dooley@microchip.com> wrote: > > On 13/07/2022 12:59, Andy Shevchenko wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > > know the content is safe > > ... > > > > > +#define BYTE_BOUNDARY 0x04 > > > > > > Without namespace? > > > > Does byte_boundary even need to be defined? > > is incrementing an address by 0x4 not kinda obvious on its own > > as to what it is doing? > > The less magic is the better. > > Btw, have you considered gpio-regmap? Can it be utilized here? Yes I have considered regmap, our register map is not mapped out to fully utilize regmap. We could use for one/two registers but not fully. > > -- > With Best Regards, > Andy Shevchenko
| |